Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder issue reflecting feedback from Eric Deutsch #33

Closed
5 tasks done
RichardBruskiewich opened this issue Sep 3, 2022 · 2 comments
Closed
5 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@RichardBruskiewich
Copy link
Collaborator

RichardBruskiewich commented Sep 3, 2022

  • 1) use check_biolink_model_compliance_of_query_graph() right away to validate QGraphs prior to query submission (note: if a KG is also part of a query, you can also use the corresponding knowledge graph method)

  • 2) We will write a "one stop" method for "semantic" (beyond schema validation) validation of TRAPI Response (including the Message components: QGraph, KnowledgeGraph and Results components)

  • 3) iterate to enhance validation (e.g. we can already ponder add detection of 'dangling nodes/edges' by iterating through node <-> edge mappings)

  • 4) we will strive to optimize performance to make the the reasoner-validator methods tractable for high throughput use

  • 5) Add Biolink Model 3.0 support (after the September 2022 Translator Relay)

@RichardBruskiewich
Copy link
Collaborator Author

RichardBruskiewich commented May 12, 2023

Item #2 covered by release v3.2.4.

Item #3 extracted into a new issue #74

Item #4 duplicates issue #28

Item #5 substantially covered by release v3.3.2.

@RichardBruskiewich
Copy link
Collaborator Author

All items covered, except item 3 moved to a new issue #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant