Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow turning lakes off (lake_option = 0) for Gridded #803

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow turning lakes off (lake_option = 0) for Gridded #803

wants to merge 1 commit into from

Conversation

rcabell
Copy link
Collaborator

@rcabell rcabell commented Jan 8, 2025

TYPE: bug fix

KEYWORDS: lakes, gridded

SOURCE: NCAR

DESCRIPTION OF CHANGES:

  • fixes an issue where lake_option=0 caused an erroneous error message about a missing route_lake_f file by resetting the lake count to 0 after the grid is scanned for channels and lakes

@rcabell rcabell requested review from aubreyd and scrasmussen January 8, 2025 00:43
scrasmussen
scrasmussen approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@scrasmussen scrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with gridded Croton case and was able to confirm bug and then that the fix worked. Nice find!

@scrasmussen scrasmussen mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrasmussen scrasmussen scrasmussen approved these changes

@aubreyd aubreyd Awaiting requested review from aubreyd

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcabell @scrasmussen