Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

164 prevent non standard keys in json #317

Merged
merged 9 commits into from
Oct 25, 2023
Merged

164 prevent non standard keys in json #317

merged 9 commits into from
Oct 25, 2023

Conversation

K20shores
Copy link
Collaborator

Closes #164

  • Detects any usage of nonstandard keys for all reaction types, products, reactants
  • Added configuration tests for arrhenius and troe reactions
  • removed the MZ whatever configuration. That was supposed to be a TS1 reaction but it wasn't. That's supposed to be made in a future task anyways

@K20shores K20shores linked an issue Oct 17, 2023 that may be closed by this pull request
Prevent non-standard keys in JSON? #164
Closed
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (88d6b5b) 97.00% compared to head (4fc4921) 96.73%.
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
- Coverage   97.00%   96.73%   -0.27%     
==========================================
  Files          34       34              
  Lines        2667     2727      +60     
==========================================
+ Hits         2587     2638      +51     
- Misses         80       89       +9
Files Coverage Δ
include/micm/configure/solver_config.hpp 91.27% <90.90%> (-0.92%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

boulderdaze
boulderdaze approved these changes Oct 17, 2023
View reviewed changes
test/unit/unit_configs/process/tunneling/valid/reactions.json
@@ -5,6 +5,7 @@
"type": "MECHANISM",
"reactions": [
{
"__my comment": {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what is this information for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to prove that these are allowed while other nonstandard keys are not

@dwfncar dwfncar mentioned this pull request Oct 24, 2023
Merged
@mattldawson mattldawson merged commit 3e4024c into main Oct 25, 2023
25 checks passed
@mattldawson mattldawson deleted the 164-prevent-non-standard-keys-in-json branch October 25, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boulderdaze boulderdaze boulderdaze approved these changes

@mattldawson mattldawson mattldawson approved these changes

@dwfncar dwfncar dwfncar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent non-standard keys in JSON?
5 participants
@K20shores @codecov-commenter @dwfncar @mattldawson @boulderdaze