-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions #307
Actions #307
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 97.00% 97.00%
=======================================
Files 34 34
Lines 2667 2667
=======================================
Hits 2587 2587
Misses 80 80 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! they all seem to run pretty fast, so maybe we just move some to only run on PRs if, in the future, the tests take longer?
Reorganized the actions so that we have explicit files for mac, windows, ubuntu, and the docker files.
For mac and ubuntu, I test both debug and release versions for gcc and clang. mac also tests 4 versions of xcode across 2 versions of mac. Windows has many tests that I stole from nlohmann/json.
I'm not sure which we should enable for PRs only.