Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions #307

Merged
merged 11 commits into from
Oct 12, 2023
Merged

Actions #307

merged 11 commits into from
Oct 12, 2023

Conversation

K20shores
Copy link
Collaborator

Reorganized the actions so that we have explicit files for mac, windows, ubuntu, and the docker files.

For mac and ubuntu, I test both debug and release versions for gcc and clang. mac also tests 4 versions of xcode across 2 versions of mac. Windows has many tests that I stole from nlohmann/json.

I'm not sure which we should enable for PRs only.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (88d6b5b) 97.00% compared to head (27d7187) 97.00%.

❗ Current head 27d7187 differs from pull request most recent head 7e22577. Consider uploading reports for the commit 7e22577 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   97.00%   97.00%           
=======================================
  Files          34       34           
  Lines        2667     2667           
=======================================
  Hits         2587     2587           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! they all seem to run pretty fast, so maybe we just move some to only run on PRs if, in the future, the tests take longer?

@mattldawson mattldawson merged commit d5946ac into main Oct 12, 2023
58 checks passed
@mattldawson mattldawson deleted the actions branch October 12, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants