Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: fix binder launch for markdown notebooks #193

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

bsipocz
Copy link
Contributor

@bsipocz bsipocz commented Dec 19, 2024

This is the alternative for #191, I use the same fix at IRSA-tutorials to be able to launch the markdown notebooks into binder.

Merge either this one or #191

(closes #191)

@bsipocz bsipocz added the infrastructure changes to the infrastructure rather than content label Dec 19, 2024
Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a couple tries, I was able to get binder running this afternoon. So I'm inclined to leave the button in. We can always reassess this decision, especially as we get other environments working a little more seamlessly.

@bsipocz bsipocz merged commit de1fff7 into NASA-NAVO:main Dec 20, 2024
11 checks passed
@bsipocz bsipocz deleted the FIX_markdown_in_binder branch December 20, 2024 19:50
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
MAINT: fix binder launch for markdown notebooks de1fff7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure changes to the infrastructure rather than content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants