Fix HSC table and columns names in UCD notebook #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoghbi-a
approved these changes
Jun 3, 2024
|
@tomdonaldson - This is a duplicate of #163, so I would go ahead with merging that (especially that also fixes the sphinx issues). |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
Fix HSC table and columns names in UCD notebook 66a068f
github-actions bot
pushed a commit
to zoghbi-a/navo-workshop
that referenced
this pull request
Jul 9, 2024
Fix HSC table and columns names in UCD notebook 66a068f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162
The tap_schema for HSC changed recently to make all table and column names lower case. The UCD notebook had a couple explicit references to those that broke when the case changed. This PR fixes those names to get the notebook to run.
During this update I noticed that multiple things in the UCD notebook seemed incorrect. I did not try to fix them here, but created #165 to track those problems.