-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version check of conda and update package versions #148
Conversation
check_env.py
Outdated
'numpy': ('1.26', None), | ||
'matplotlib': ('3.8', None), | ||
'jupyterlab': ('4.0', None), | ||
'astropy': ('6.0', None), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether we can do this yet, I think we need to disentangle this version check from the conda environment versions.
E.g. the notebooks should work with older astropy, no need to get the latest version (especially that a lot of packages in the ecosystem is still incompatible with astropy6).
So I would keep this list for the minimum versions, we do check for these in CI anyway, and the conda env separate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsipocz so are you recommending to set the environment check to, say, version 5.3, and leave the environment.yml
entry for astropy as-is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or even leave 5.2 and we bump versions when we run into limitations (or when they are getting a bit out of date).
Totally separately you can update the versions in environment.yml
as that is a combination users are expected to setup for the workshop itself (in my mind, the notebooks should be able to run separately from that specific environment, and indeed we test with the minimum versions separatetly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry I wasn't clear. This comment is true for all the minimum versions, bump them when needed or when SPEC0 or similar would say they are outdated, but don't require latest and greatest by default.
- numpy>=1.26 | ||
- astropy>=6.0 | ||
- matplotlib>=3.8 | ||
- jupyterlab>=4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up: There was an incompatibility with the md notebooks with jupyter-server 2+, so we need to keep an eye on it that none of these brings in that package as a dependency (or if they do, they pick up the correct version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in for integration with next CI PR.
Add version check of conda and update package versions 3010909
Fixes #142