Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set data catalog filters to be closed by default #1243

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

vgeorge
Copy link
Contributor

@vgeorge vgeorge commented Nov 5, 2024

Related Ticket: https://github.com/US-GHG-Center/ghgc-architecture/issues/391

Description of Changes

With this change the data catalog filters controls are initially displayed in a closed state when the page loads.

Notes & Questions About Changes

This affects two pages: Data Catalog and Exploration.

Validation / Testing

Visit the following URLs (on localhost), all of them should display the filter controls closed on page load:

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 117db83
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/672a1a26534c5d0008592470
😎 Deploy Preview https://deploy-preview-1243--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with and without selected filters on both, Data Catalog page and E&A modal using the preview deployment urls and localhost. It works as expected ✅

@vgeorge vgeorge merged commit 572459e into main Nov 5, 2024
9 checks passed
@vgeorge vgeorge deleted the 391-data-catalog-filters-default-to-closed branch November 5, 2024 17:03
@AliceR AliceR mentioned this pull request Nov 11, 2024
AliceR added a commit that referenced this pull request Nov 12, 2024
## 🎉 Features
* Card image/description independent of hero image/description by
@dzole0311 in #1244

## 🚀 Improvements
* Cookie consent code cleanup by @snmln in
#1199 , and @hanbyul-here in
#1240 , and @hanbyul-here in
#1241
* Add ADR about design system change by @j08lue in
#890
* Update condition to run playwright tests on release branches by
@dzole0311 in #1228
* Update STYLE_GUIDE.md by @AliceR in
#1227
* Fix lint configuration by @AliceR in
#1219
* Add tests for the AOI feature specification by @AliceR in
#1216
* Set data catalog filters to be closed by default by @vgeorge in
#1243
* Update tsconfig and make nav interfaces exposable for consumption by
@sandrahoang686 in #1223

## 🐛 Fixes
* Hotfix to hide the external link badge from cards by @dzole0311 in
#1231

## New Contributors
* @vgeorge made their first contribution in
#1243

**Full Changelog**:
v5.9.0...v5.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants