Handle the case when source parameters + render parameters are both empty #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hanbyul-here
force-pushed
the
1028-empty-source-param
branch
from
8740859
to
86e83fa
Compare
dzole0311
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1028
Description of Changes
Bluetarp data from stac backend: https://staging.openveda.cloud/api/stac/collections/blue-tarp-planetscope
Notes & Questions About Changes
This makes me wonder about if we can validate anything about render parameters - ex. When there is no render parameter at all from stac back-end points, is there any way to be sure that this dataset is meant to be without render parameters ? - Tagging @smohiudd for this question.
Testing
Test this branch with veda-config's globalscope bluetarp dataset.