fix: update get_username function #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smohiudd
approved these changes
Apr 29, 2024
anayeaye
approved these changes
Apr 29, 2024
| return token["username"] | ||
| def get_username(token: Annotated[Dict[Any, Any], Depends(validated_token)]) -> str: | ||
| logger.info(f"\nToken {token}") | ||
| result = token["username"] if "username" in token else token.get("sub", None) |
There was a problem hiding this comment.
I'm mixed about having a default when we might want to fail but because this depends on validation I think it is OK? We can decide after it works or not
There was a problem hiding this comment.
dbb62fb Perhaps we can raise the error instead?
There was a problem hiding this comment.
f640fdf change reverted since we don't want to be blocked and could forget about this change later on
botanical
added a commit
that referenced
this pull request
May 6, 2024
### Breaking - #356 #### Breaking changes notes Breaking: `VEDA_COGNITO_DOMAIN` configuration now required along with one time administrator step to update existing user pool client allowed callback urls with the ingest-api's URL ### Added - #342 - #330 - #323 ### Changed/Updated - #355 - #340 ### Fixed 1. - #367 2. - #365 3. - #361 4. - #360 5. - #358 8. - #345 9. - #344 12. - #339 13. - #338 14. - #337 15. - #335 16. - #334 17. - #331 20. - #329 21. - #327 22. - #326 23. - #325 24. - #324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
NASA-IMPACT/veda-data-airflow#134
#347
What?
subifusernamedoesn't exist in tokenWhy?
subis a more definitive identifier because it represents a unique identifier compared tousernameTesting?