Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few updates #51

Closed
wants to merge 10 commits into from
Closed

Few updates #51

wants to merge 10 commits into from

Conversation

dzole0311
Copy link
Collaborator

@dzole0311 dzole0311 commented Oct 4, 2024

  1. Update the inactive scenario lines in the chart to be more visible
  2. Update the loading state for the chart so that it shows appropriate loading spinner and messages. Address invalid data with a valid error message
  3. Change from square draggable area to a buffer
  4. Scale buffer on zoom
  5. Make request depend on GIS_TOKEN env variable

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for eic-mobile-demo ready!

Name Link
🔨 Latest commit ca05c99
🔍 Latest deploy log https://app.netlify.com/sites/eic-mobile-demo/deploys/67003dd278193500085db94f
😎 Deploy Preview https://deploy-preview-51--eic-mobile-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am right now constantly getting the no data over oceans screen, from the moment the app loads:

image

Is this an issue with the service?

It leaves me, as a user, puzzled what is going on, since the marker already is placed on land.

Awesome work on the circular marker!

@dzole0311
Copy link
Collaborator Author

Closing this as most of the commits here were merged via #52

@j08lue It's partially the service. I added a GIS_TOKEN to the fetch request here, but because no valid token is set as an .env variable in the repo, the service returns errors.

@dzole0311 dzole0311 closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants