Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save activity names from procedural goals #1568

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Save activity names from procedural goals #1568

merged 2 commits into from
Oct 2, 2024

Conversation

JoelCourtney
Copy link
Contributor

  • Tickets addressed: none
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This PR saves activity names set by procedural goals to the database.

Verification

I added an e2e test to make sure the names successfully made it to the db.

@JoelCourtney JoelCourtney added fix A bug fix scheduling Anything related to the scheduling domain labels Sep 25, 2024
@JoelCourtney JoelCourtney self-assigned this Sep 25, 2024
@JoelCourtney JoelCourtney requested a review from a team as a code owner September 25, 2024 17:58
@JoelCourtney JoelCourtney changed the title Fix/save activity names Save activity names from procedural goals Sep 25, 2024
@JoelCourtney JoelCourtney force-pushed the fix/save-activity-names branch from dec21b5 to 4328d4b Compare September 25, 2024 20:11
skovati
skovati approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@skovati skovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few non-blocking comments

e2e-tests/src/test/java/gov/nasa/jpl/aerie/e2e/SchedulingTests.java Show resolved Hide resolved
.../java/gov/nasa/ammos/aerie/procedural/examples/fooprocedures/procedures/SampleProcedure.java Show resolved Hide resolved
scheduler-driver/src/main/java/gov/nasa/jpl/aerie/scheduler/model/SchedulingActivity.java Show resolved Hide resolved
.../java/gov/nasa/ammos/aerie/procedural/examples/fooprocedures/procedures/SampleProcedure.java Show resolved Hide resolved
@dandelany
Copy link
Collaborator

Merging for release (with permission from @JoelCourtney) - thanks!

@dandelany dandelany merged commit 06bad80 into develop Oct 2, 2024
10 checks passed
@dandelany dandelany deleted the fix/save-activity-names branch October 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skovati skovati skovati approved these changes

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-backend

@srschaffJPL srschaffJPL Awaiting requested review from srschaffJPL srschaffJPL is a code owner automatically assigned from NASA-AMMOS/aerie-backend

Assignees

@JoelCourtney JoelCourtney

Labels
fix A bug fix scheduling Anything related to the scheduling domain
Projects
Aerie
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoelCourtney @dandelany @skovati