Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trivyignore file to ignore false positive CVEs in security scan #1546

Merged
merged 1 commit into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/config/.trivyignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# List of CVEs to ignore in our security scans in Publish workflow
# see https://aquasecurity.github.io/trivy/v0.53/docs/configuration/filtering/#trivyignore

# These were determined to be false positives caused by the `gosu` library
# which is installed by the postgres docker container and does not use the entirety of the Go stdlib
# for details see:
# - https://github.com/tianon/gosu/blob/master/SECURITY.md
# - https://github.com/NASA-AMMOS/aerie/pull/1546
CVE-2023-24538
CVE-2023-24540
CVE-2024-24790
5 changes: 4 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,10 @@ jobs:
fail-fast: false
name: scan ${{ matrix.image }}
steps:
- uses: actions/checkout@v4

- name: Scan ${{ matrix.image }} for vulnerabilities
uses: aquasecurity/trivy-action@master
uses: aquasecurity/trivy-action@0.24.0
with:
image-ref: ${{ env.REGISTRY }}/${{ env.OWNER }}/${{ matrix.image }}:develop
ignore-unfixed: true
Expand All @@ -158,6 +160,7 @@ jobs:
template: "@/contrib/html.tpl"
scanners: "vuln"
output: "${{ matrix.image }}-results.html"
trivyignores: .github/config/.trivyignore

- name: Upload ${{ matrix.image }} scan results
if: always()
Expand Down
Loading