Make Scheduler containers use the correct Envvar #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
added
the
breaking change
dandelany
approved these changes
Jul 22, 2024
It now matches our docs, our docker containers, and is in sync with the rest of Aerie
Mythicaeda
force-pushed
the
fix/scheduler-db-envvar
branch
from
0796cd0 to
5a5cc9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It now matches our docs, our docker containers, and is in sync with the rest of Aerie.
Flagged as "breaking" as this may impact customer deployments.
Verification
Manually verified the correct envvar is now being used.
Documentation
This change will need to be called out in our upgrade docs, but the rest of our docs already assumed that the envvar was called this.
Sister PR to update the v2.8.0 upgrade docs is here