Fix DiscreteEffects.remove #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscreteEffects.remove is one of two methods meant to implement a FIFO queue resource (the other is DiscreteEffects.add). However, it was written to remove the last element of the queue, when it should have removed the first element.
mattdailis
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DiscreteEffects.remove is one of two methods meant to implement a FIFO queue resource (the other is DiscreteEffects.add). However, it was written to remove the last element of the queue, when it should have removed the first element.
Verification
Tested in the CADRE model while working with @bashbash
Documentation
Documentation for this function was correct, now the code matches that documentation.
Future work
N/A