Added a method to check for static parameters inside of an ActivityType #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdailis
approved these changes
Jul 16, 2024
...ramework-processor/src/main/java/gov/nasa/jpl/aerie/merlin/processor/MissionModelParser.java
Show resolved
Hide resolved
mattdailis
force-pushed
the
bug/check-for-static-parameters
branch
from
c8c9e0a to
1219b52
Compare
cohansen
force-pushed
the
bug/check-for-static-parameters
branch
from
1219b52 to
1309cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After loading the activity types during mission model building I added a check for any parameters we've loaded that are marked as being static.
Verification
Tested manually, to test mark a parameter inside of Bananation and run the assemble task, it should fail.
Documentation
NA
Future work
NA