-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a table to track the default view for a given mission model #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
reviewed
May 30, 2024
deployment/hasura/migrations/Aerie/4_mission_model_default_view/down.sql
Outdated
Show resolved
Hide resolved
Mythicaeda
reviewed
May 30, 2024
deployment/hasura/migrations/Aerie/4_mission_model_default_view/up.sql
Outdated
Show resolved
Hide resolved
Mythicaeda
reviewed
Jun 3, 2024
deployment/postgres-init-db/sql/tables/merlin/mission_model.sql
Outdated
Show resolved
Hide resolved
deployment/hasura/metadata/databases/tables/merlin/mission_model.yaml
Outdated
Show resolved
Hide resolved
Mythicaeda
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cohansen
force-pushed
the
feature/add-default-mission-model-view
branch
from
June 6, 2024 22:16
eadfc65
to
2d17e09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a mapping table that users can use to make a default view for a given mission model. When the user navigates to the plan the UI will load the default view if one is set.
Verification
Manually tested in the UI to make sure the default view is being loaded if it's set.
Documentation
None
Future work
Add a UI to enable creating / deleting these default views.
Associated frontend PR: NASA-AMMOS/aerie-ui#1310