Update GH Action Versions used in Workflows

[Mythicaeda]

• Tickets addressed: Hotfix
• Review: By commit
• Merge strategy: Merge (no squash)

Description

Github actions are transitioning from Node 16 to Node 20. This PR is to update our workflows to use the node 20 versions of all actions (v4).

There were some breaking changes in the upload/download artifact action, that will impact our usage, specifically being unable to upload two artifacts with the same name. This specifically impacts our Security Scan, Publish, and Test workflows.

Verification

Successful execution of each workflow with no Node16 warnings will validate this PR:

• CLOC
• DB Migrations
• Load Test
• Test/E2E Tests
• Create JNISPICE
• Deploy to GH Pages
• Publish (Deploy step is untestable due to branch restrictions)
• Security Scan

Documentation

No doc updates needed.

[skovati]

This looks great! I'll just note that we'll need to make these changes on other Aerie repos (UI and Gateway) as well.

[dandelany]

👍 looks good to me also - chatted with @Mythicaeda yesterday about a couple questions but I'm happy with this! For reference, this is the successful run of the Publish workflow (not run by PR Checks like the others): https://github.com/NASA-AMMOS/aerie/actions/runs/7995540299

One note: as a result of the changes to upload_artifact noted by @Mythicaeda above, the "Security Scan" workflow now creates two artifacts called "Security Scan - java" and "Security Scan - javascript". When we do a release, the "Security Scan" artifact was attached to the release by the workflows in aerie-release, so I will add a PR to aerie-release to look for the two separate scans in future instead of the one combined one.