-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence background transpiler #1332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your comment about merging this into the other PR, this was just an easier first review since it was more digestible.
a3f8086
to
0ac1dc3
Compare
Just want to ask a perhaps dumb question. This essentially polls every 5 minutes. Is there any way we can change from a pull to a push model? IE be notified of changes and trigger transpilation, but throttle it to every 5 minutes? That way, no cycles are wasted pulling and transpiling when there are no changes? |
@dyst5422 I like the idea of combining these two concepts. We can trigger transpilation whenever the user uploads a new command dictionary or mission model. The current polling mechanism can help address edge cases where users operate outside the sequencing server and Hasura GraphQL Actions. This typically occurs when users bypass the @dandelany Do you want me to explore this option, or create a ticket to address this later? I want to get these new changes to Clipper to try it out and see if it helps them in the thread test. |
0ac1dc3
to
593f875
Compare
593f875
to
35ed269
Compare
Sorry for the ignorance, how does use of the api by clipper bypass |
@dyst5422 Not at all, I noticed Aerie UI was doing this. When the user creates a new authoring logic it does not use the I talked to @dandelany and @joswig about this yesterday and we were going to make a ticket to add a push model to the code at a later time. We had some important EDSL tickets come from clipper that me and Matt need to prototype. |
It's concerning to me that there are multiple paths to get an expansion in the system as we clearly have processes we want to execute as part of the paths through and don't have control over that flow. Is there interest in closing those alternate paths to getting an expansion into the system? 100% support the appropriate prioritization. |
35ed269
to
f2629cd
Compare
We will address the UI hole, which should resolve most of the issues. However, since missions/users have visibility into the Hasura CLI, they can still see all available GQL and potentially bypass our recommended queries. This is a very unlikely situation, but users are going to do weird things especially if they are outside of Aerie. |
Create a new ticket to create a push model. |
f2629cd
to
9ea4ba7
Compare
9ea4ba7
to
fde880d
Compare
fde880d
to
2757293
Compare
… generation downstream * Fetches the latest command dictionary, mission model, and expansion logic on a regular basis.Transpiles and caches the results. * Help to pay the upfront cost that we are seeing on Clipper where there expansion logic takes about 15 minutes to generate a expansion set of 130 authoring logic.
*Triggers the transpilation process upon server startup and at regular intervals (every 5 minutes).
2757293
to
3743ba7
Compare
Going to revise this code when I work on #1349 |
Description
Part 2 of 2 for #1324
You need PR #1324 merged first
This PR introduces a background transpiler process to help improve the upfront cost of creating an expansion set or sequence expansion
Changes:
Verification
Manual testing with Clipper mission model and command dictionary