Add Missing Filter in Commit Merge #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upserting the Presets for Activity Directives was missing filters on the snapshot id and the merge request id.
Verification
DBTests were added.
presetOnlyPullsFromSourceSnapshotasserts that the potential bug caused by a lack of snapshot id filter does not occur.presetUnaffectedByUnrelatedSnapshotmirrors a strange scenario seen on a Clipper venue that was causing merge issues, where for some reason a preset recorded on an unrelated plan's snapshot was attempting to be set when committing the merge.Documentation
No docs need to be updated
Future work