Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rootfinding robust to functions with discontinuities #1193

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Make rootfinding robust to functions with discontinuities #1193

merged 1 commit into from
Oct 13, 2023
+409 −87

Conversation

adrienmaillard
Copy link
Contributor

Description

Verification

Two tests on discontinuous functions and one test on f(x) = x^2

Documentation

None

Future work

None

@adrienmaillard adrienmaillard requested a review from a team as a code owner October 12, 2023 00:46
@adrienmaillard adrienmaillard temporarily deployed to e2e-test October 12, 2023 00:47 — with GitHub Actions Inactive
@adrienmaillard adrienmaillard self-assigned this Oct 12, 2023
@adrienmaillard adrienmaillard added fix A bug fix scheduling Anything related to the scheduling domain clipper Requests from the Europa Clipper project labels Oct 12, 2023
@adrienmaillard adrienmaillard added this to the FY23 Q4 - Bug Fixes milestone Oct 12, 2023
Mythicaeda
Mythicaeda reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Mythicaeda Mythicaeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Awaiting the changes we discussed yesterday.

merlin-sdk/src/main/java/gov/nasa/jpl/aerie/merlin/protocol/types/Duration.java Outdated Show resolved Hide resolved
scheduler-driver/src/main/java/gov/nasa/jpl/aerie/scheduler/EquationSolvingAlgorithms.java Outdated Show resolved Hide resolved
scheduler-driver/src/test/java/gov/nasa/jpl/aerie/scheduler/RootfindingTest.java Outdated Show resolved Hide resolved
@adrienmaillard adrienmaillard removed the request for review from cohansen October 13, 2023 16:20
@adrienmaillard adrienmaillard temporarily deployed to e2e-test October 13, 2023 22:10 — with GitHub Actions Inactive
@adrienmaillard adrienmaillard temporarily deployed to e2e-test October 13, 2023 22:43 — with GitHub Actions Inactive
@adrienmaillard adrienmaillard merged commit 98e993b into develop Oct 13, 2023
6 checks passed
@adrienmaillard adrienmaillard deleted the 1139-fix-rootfinding branch October 13, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mythicaeda Mythicaeda Mythicaeda approved these changes

Assignees

@adrienmaillard adrienmaillard

Labels
clipper Requests from the Europa Clipper project fix A bug fix scheduling Anything related to the scheduling domain
Projects
None yet
Milestone
FY23 Q4 - Bug Fixes
Development

Successfully merging this pull request may close these issues.

Scheduler rootfinding fails with ZeroDerivativeException
2 participants
@adrienmaillard @Mythicaeda