Improve ConstraintAction Error Messages

[Mythicaeda]

• Tickets addressed: Hotfix
• Review: By commit
• Merge strategy: Merge (no squash)

Description

Follow up to #1169.

The action will now correctly distinguish between a plan never being simulated and a specified sim dataset not existing when erroring on resultsHandle$ being empty.

Additionally, the serializer for SimDatasetMismatch now refers to the correct extension.

Verification

A bindings test has been added. The bindings test fo the SimDatasetMismatch exception has been updated.

Documentation

No docs changes needed.

[mattdailis]

I'm highly supportive of improving these error messages 🚀 I was preparing for a demo this morning, and ran into "input mismatch exception". I think longer term we'll want the UI to specially handle these messages.

As far as this PR is concerned, I want to workshop the messages to make sure they are accurate enough to be actionable. The two cases seem to be:

• The provided simulation dataset id either doesn't exist, or it does exist, but isn't associated with this plan. Can we put this succinctly?
• No simulation dataset id was provided, and the latest revision of the plan has never been simulated

[Mythicaeda]

The two cases seem to be:

There are three cases, actually:

1. There was a simulation dataset id specified, but that dataset doesn't exist
2. There was a simulation dataset id specified, and that dataset exists, but it's a dataset for a different plan
3. There was no simulation dataset id specified, and the plan has never been simulated (note that plan revision is not actually used, it only still exists as a param due to the unused UncachedSimulationService. All checking a plan revision does is prove that the plan exists)

Cases 1 and 3 share an error class but have unique error messages in the cause field. Case 2 has its own error class.

[mattdailis]

Couple clarifying questions - I have a feeling the messages might still be a bit misleading

[mattdailis]

💯