Fix Scheduling DSL Typescript Action #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
added
fix
adrienmaillard
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two bugs were fixed:
planIdparameter forschedulingDSLTypscriptwas added to the Action definition. Because this parameter is optional, this change is not breaking (verified manually).planIdnot being specified. With fix (1), it was unable to parse anullplanId.Verification
Re: 1: The GQL query has been updated with the action.
Re: 2: We already have two tests for that endpoint, one which provides the
planIdand one which doesn't. The reason this slipped by is the one that provides theplanIdwas a Bindings Test, meaning it was hitting the scheduler directly instead of using a GQL query. I have corrected this in my work for #1057 by splitting the tests into two tests, a BindingsTest and a ScheudlingDSLTest.Documentation
No docs need to be updated.