Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the cached Constraint results to match action results #1156

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

Mythicaeda
Copy link
Contributor

Description

Updated the parser for constraint violations so that the cached run has the same key names as the action response.

Verification

Wrote a JSON parser while working on #1057 that successfully parses both the checkConstraints action response and the cached values from constraint_run.

Documentation

No docs were invalidated

Future work

None

@Mythicaeda Mythicaeda added the fix A bug fix label Sep 27, 2023
@Mythicaeda Mythicaeda requested a review from a team as a code owner September 27, 2023 16:43
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 27, 2023 16:43 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 27, 2023 16:43 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test September 27, 2023 16:43 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda added the constraints Anything related to the constraints domain label Sep 27, 2023
@JoelCourtney
Copy link
Contributor

@jeffpamer FYI this will impact your UI code

@JoelCourtney
Copy link
Contributor

Don't merge until the UI has a PR to keep up to date

@Mythicaeda Mythicaeda added the DON'T MERGE Do Not Merge This Branch label Sep 28, 2023
@jeffpamer
Copy link
Contributor

Looks like this should be a pretty small change on our end if I'm interpreting this correctly. I'll try to get a UI PR up this afternoon or first thing tomorrow.

@jeffpamer
Copy link
Contributor

Upon further investigation this does not appear to be a breaking change for the UI as we are currently not reading anything out of constraint_run. If we do start using the cached run results in the future, it looks like after this change the schema will match the shape we are already expecting for constraint check results.

@jeffpamer jeffpamer removed the DON'T MERGE Do Not Merge This Branch label Oct 3, 2023
@Mythicaeda Mythicaeda force-pushed the fix/schema-mismatch-constraints branch from 62e20de to 68e0b2a Compare October 3, 2023 20:09
@Mythicaeda Mythicaeda temporarily deployed to e2e-test October 3, 2023 20:09 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test October 3, 2023 20:09 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda temporarily deployed to e2e-test October 3, 2023 20:09 — with GitHub Actions Inactive
@Mythicaeda Mythicaeda merged commit e72ed05 into develop Oct 3, 2023
10 checks passed
@Mythicaeda Mythicaeda deleted the fix/schema-mismatch-constraints branch October 3, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
constraints Anything related to the constraints domain fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema Mismatch Between Cached Constraint Run and Action Response
3 participants