Fix Interval.Horizon #1154
Merged
Fix Interval.Horizon #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelCourtney
added
fix
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
adrienmaillard
approved these changes
Oct 3, 2023
JoelCourtney
force-pushed
the
fix/interval-horizon
branch
from
177f84f to
cd6a244
Compare
JoelCourtney
force-pushed
the
fix/interval-horizon
branch
from
cd6a244 to
e3be000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The result currently returned by
Interval.Horizon()is an interval fromDuration.MIN_VALUEtoDuration.MAX_VALUE. I wrote that code, and I cannot fathom why I made that decision, when the planning horizon is readily accessible in that function already. I'm here to atone for my mistakes.Verification
Wrote an AST test to make sure the result equals the plan bounds.
Documentation
Future work