Implement dedicated rollingwindow constraint node #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelCourtney
added
feature
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
Mythicaeda
reviewed
Sep 6, 2023
constraints/src/main/java/gov/nasa/jpl/aerie/constraints/tree/RollingThreshold.java
Outdated
Show resolved
Hide resolved
merlin-server/constraints-dsl-compiler/src/libs/constraints-edsl-fluent-api.ts
Outdated
Show resolved
Hide resolved
constraints/src/main/java/gov/nasa/jpl/aerie/constraints/tree/RollingThreshold.java
Outdated
Show resolved
Hide resolved
constraints/src/main/java/gov/nasa/jpl/aerie/constraints/tree/RollingThreshold.java
Show resolved
Hide resolved
JoelCourtney
force-pushed
the
1015-implement-dedicated-rollingwindow-constraint-node
branch
from
d6e68bd to
794143e
Compare
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
Mythicaeda
approved these changes
Sep 14, 2023
JoelCourtney
force-pushed
the
1015-implement-dedicated-rollingwindow-constraint-node
branch
from
e013ee9 to
130e132
Compare
JoelCourtney
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
JoelCourtney
deleted the
1015-implement-dedicated-rollingwindow-constraint-node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new node
Constraint.RollingThreshold(spans, width, threshold, algorithm)that detects when the cumulative duration ofspansexceeds or falls short ofthresholdin anywidthinterval.algorithmdecides both whether violations are reported by highlighting the individual spans that caused the violation or by highlighting the whole interval over which it happened, and whether it looks for excess or deficit duration.Verification
Documentation
I know that the constraints documentation is seriously lacking, especially in tutorials for common constraint patterns. I'll get that section started with this.
Future work