Skip to content

Commit

Permalink
Remove properties from Event payload
Browse files Browse the repository at this point in the history
  • Loading branch information
JoelCourtney authored and pranav-super committed Nov 4, 2024
1 parent 02dc287 commit b7c81f5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ data class ExternalEvent(
/** The derivation group that this event comes from. */
val derivationGroup: String,
override val interval: Interval,
/** The properties associated with this event. */
val properties: Map<String, SerializedValue>
): IntervalLike<ExternalEvent> {
override fun withNewInterval(i: Interval) = ExternalEvent(key, type, source, derivationGroup, i, properties)
override fun withNewInterval(i: Interval) = ExternalEvent(key, type, source, derivationGroup, i)
}
Original file line number Diff line number Diff line change
Expand Up @@ -1036,9 +1036,6 @@ public Map<String, List<ExternalEvent>> getExternalEvents(final PlanId planId, f
source_range
start_time
valid_at
external_event {
properties
}
}
}""".formatted(derivationGroups);
final JsonObject eventsResponse = postRequest(eventsRequest).get();
Expand Down Expand Up @@ -1190,8 +1187,7 @@ private List<ExternalEvent> parseExternalEvents(final JsonArray eventsJson, fina
e.getString("event_type_name"),
e.getString("source_key"),
e.getString("derivation_group_name"),
Interval.between(start, end),
serializedValueP.parse(e.getJsonObject("external_event").getJsonObject("properties")).getSuccessOrThrow().asMap().get()
Interval.between(start, end)
));
}
return result;
Expand Down

0 comments on commit b7c81f5

Please sign in to comment.