Skip to content

Commit

Permalink
remove uploadWithoutError
Browse files Browse the repository at this point in the history
  • Loading branch information
pranav-super committed Oct 15, 2024
1 parent 32c5f9f commit b060da3
Showing 1 changed file with 2 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ protected List<DerivedEvent> getDerivedEvents(String end) throws SQLException {
* Repeated function that uploads a source and various events, as well as related types.
* Used in:
* - ExternalEventTests.java:
* + BASIC TESTS (uploadWithoutError, basicDerivedEvents, derivationGroupComp)
* + BASIC TESTS (derivationGroupComp)
* + final duplication tests (duplicateSource, duplicatedDG)
* + superDerivedEvents
*
Expand Down Expand Up @@ -345,20 +345,10 @@ protected void insertStandardTypes() throws SQLException {
@Nested
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
class BasicTests {
/**
* This first test is to verify that a simple upload works, regardless of if its output is correct.
* As we do not upload a file we just run the queries that would be run if files were uploaded,
* namely tests 01-04 from SSMO-MPS/mission-data-sandbox/derivation_test.
*/
@Test
void uploadWithoutError() {
assertDoesNotThrow(() -> upload_source(dg));
}

/**
* This test uploads data (tests 01-04 from SSMO-MPS/mission-data-sandbox/derivation_test) and then confirms
* derivation_group_comp view associated with upload performs as expected.
* This test alone is rigorous enough for derivation_group_comp view, and is an extension of uploadWithoutError.
* This test alone is rigorous enough for derivation_group_comp view.
*/
@Test
void derivationGroupComp() throws SQLException {
Expand Down

0 comments on commit b060da3

Please sign in to comment.