Skip to content

Commit

Permalink
Merge pull request #1546 from NASA-AMMOS/ops/trivyignore-false-positives
Browse files Browse the repository at this point in the history
Add trivyignore file to ignore false positive CVEs in security scan
  • Loading branch information
dandelany authored Sep 5, 2024
2 parents fd167b1 + ec160c3 commit 647c66d
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
11 changes: 11 additions & 0 deletions .github/config/.trivyignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# List of CVEs to ignore in our security scans in Publish workflow
# see https://aquasecurity.github.io/trivy/v0.53/docs/configuration/filtering/#trivyignore

# These were determined to be false positives caused by the `gosu` library
# which is installed by the postgres docker container and does not use the entirety of the Go stdlib
# for details see:
# - https://github.com/tianon/gosu/blob/master/SECURITY.md
# - https://github.com/NASA-AMMOS/aerie/pull/1546
CVE-2023-24538
CVE-2023-24540
CVE-2024-24790
5 changes: 4 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,10 @@ jobs:
fail-fast: false
name: scan ${{ matrix.image }}
steps:
- uses: actions/checkout@v4

- name: Scan ${{ matrix.image }} for vulnerabilities
uses: aquasecurity/trivy-action@master
uses: aquasecurity/trivy-action@0.24.0
with:
image-ref: ${{ env.REGISTRY }}/${{ env.OWNER }}/${{ matrix.image }}:develop
ignore-unfixed: true
Expand All @@ -158,6 +160,7 @@ jobs:
template: "@/contrib/html.tpl"
scanners: "vuln"
output: "${{ matrix.image }}-results.html"
trivyignores: .github/config/.trivyignore

- name: Upload ${{ matrix.image }} scan results
if: always()
Expand Down

0 comments on commit 647c66d

Please sign in to comment.