Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simulation snapshot panel interactions #913

Merged
merged 11 commits into from
Oct 9, 2023
Merged

Add simulation snapshot panel interactions #913

merged 11 commits into from
Oct 9, 2023

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Oct 2, 2023

resolves #878

To test:

  1. Create a plan and add some directives
  2. Run a simulation
  3. Change some simulation arguments
  4. Run another simulation
  5. Create a snapshot
  6. Add more directives
  7. Run another simulation
  8. Create another snapshot
  9. Open the Simulation and Plan Metadata panels
  10. Verify that clicking on a snapshot displays the snapshot bar at the top
  11. Verify that clicking on different snapshots automatically filters out the relevant past simulations
  12. Verify that the "Simulation" button is toggleable
    Screenshot 2023-10-02 at 11 26 40 AM
  13. Verify that the "Snapshot" button is off by default and is toggleable also
    Screenshot 2023-10-02 at 11 28 21 AM
  14. Verify that the "Snapshot" filter button filters the snapshot list by what is relevant to the selected simulation dataset

@duranb duranb requested a review from a team as a code owner October 2, 2023 18:30
@duranb duranb requested review from jeffpamer and AaronPlave October 2, 2023 18:30
@duranb duranb mentioned this pull request Oct 2, 2023
Closed
@duranb duranb changed the title Feat: 878 simulation snapshot panel interactions Add simulation snapshot panel interactions Oct 2, 2023
@duranb
Copy link
Collaborator Author

duranb commented Oct 3, 2023

@AaronPlave this should be ready for another look for whenever you get a chance. Thank you!

@AaronPlave AaronPlave mentioned this pull request Oct 3, 2023
Merged
@duranb duranb force-pushed the feature/878-simulation-snapshot-panel-interactions branch from cdebb07 to aec806b Compare October 9, 2023 17:09
@duranb duranb temporarily deployed to test-workflow October 9, 2023 17:09 — with GitHub Actions Inactive
@duranb duranb merged commit c8aa142 into develop Oct 9, 2023
4 checks passed
@duranb duranb deleted the feature/878-simulation-snapshot-panel-interactions branch October 9, 2023 22:35
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@duranb
Add simulation snapshot panel interactions (#913)
5319788 
* add simulation dataset id to URL when choosing dataset or snapshot
* add filter button to simulation list and plan snapshot list
* add snapshot control bar to plan page
* make console affect layout
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@duranb @JosephVolosin
Add simulation snapshot panel interactions (#913)
bc6e075 
* add simulation dataset id to URL when choosing dataset or snapshot
* add filter button to simulation list and plan snapshot list
* add snapshot control bar to plan page
* make console affect layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@jeffpamer jeffpamer Awaiting requested review from jeffpamer jeffpamer is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simulation panel/snapshot panel interactions
2 participants
@duranb @AaronPlave