Units UI #845
Closed
Units UI #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duranb
force-pushed
the
feat/822-units-ui
branch
from
f784c4b to
ee3299e
Compare
duranb
force-pushed
the
feat/822-units-ui
branch
from
ee3299e to
7978f78
Compare
duranb
force-pushed
the
feat/822-units-ui
branch
from
c1e5184 to
2eabdff
Compare
duranb
force-pushed
the
feat/822-units-ui
branch
from
1ec5a02 to
4fa46f0
Compare
duranb
force-pushed
the
feat/822-units-ui
branch
from
e4d603e to
0d8ad99
Compare
duranb
had a problem deploying
to
test-workflow
GitHub Actions
Failure
duranb
had a problem deploying
to
test-workflow
GitHub Actions
Failure
duranb
force-pushed
the
feat/822-units-ui
branch
from
b0ac938 to
6da9d79
Compare
duranb
force-pushed
the
feat/822-units-ui
branch
from
6da9d79 to
043bdd1
Compare
duranb
had a problem deploying
to
test-workflow
GitHub Actions
Failure
duranb
force-pushed
the
feat/822-units-ui
branch
from
043bdd1 to
9e4c642
Compare
duranb
had a problem deploying
to
test-workflow
GitHub Actions
Failure
duranb
force-pushed
the
feat/822-units-ui
branch
from
9e4c642 to
a578b35
Compare
duranb
had a problem deploying
to
test-workflow
GitHub Actions
Failure
duranb
had a problem deploying
to
test-workflow
GitHub Actions
Failure
duranb
force-pushed
the
feat/822-units-ui
branch
from
da1cc9e to
a2bf396
Compare
duranb
had a problem deploying
to
test-workflow
GitHub Actions
Failure
add "compact" mode to ValueSourceBadge component for reusability fix issue where "display:none" prevents proper padding calculation
include units in db query
duranb
force-pushed
the
feat/822-units-ui
branch
from
a2bf396 to
9f474fd
Compare
duranb
had a problem deploying
to
test-workflow
GitHub Actions
Failure
|
closing in favor of #968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #822
depends on NASA-AMMOS/aerie#1055
Figma: https://www.figma.com/file/sqQoaecl7WgCFFyIC4KnK2/Aerie-Units-and-Legends?node-id=22%3A9465&mode=dev
To test:
BakeBananaBreadandBiteBananaactivitiesBiteBananaspan