Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show variables and globals in form view #1536

Merged
merged 18 commits into from
Nov 9, 2024

Conversation

joswig
Copy link
Collaborator

@joswig joswig commented Oct 31, 2024

Fixes #1317

Form view has select box to switch between literal value and reference

Screenshot 2024-11-04 at 5 01 37 PM

@joswig joswig force-pushed the feat/show_variables_in_form_view branch from 5dc7489 to f3eb04c Compare November 5, 2024 01:07
@joswig joswig marked this pull request as ready for review November 5, 2024 01:07
@joswig joswig requested a review from a team as a code owner November 5, 2024 01:07
@joswig joswig force-pushed the feat/show_variables_in_form_view branch from 37a6cca to bb44e81 Compare November 5, 2024 23:48
src/components/sequencing/form/ArgEditor.svelte Outdated Show resolved Hide resolved
src/components/sequencing/SequenceEditor.svelte Outdated Show resolved Hide resolved
src/components/sequencing/form/ArgTitle.svelte Outdated Show resolved Hide resolved
src/components/sequencing/form/ArgTitle.svelte Outdated Show resolved Hide resolved
src/components/sequencing/form/ArgTitle.svelte Outdated Show resolved Hide resolved
src/components/sequencing/form/EnumEditor.svelte Outdated Show resolved Hide resolved
src/components/sequencing/form/SelectedCommand.svelte Outdated Show resolved Hide resolved
src/components/sequencing/form/SelectedCommand.svelte Outdated Show resolved Hide resolved
src/utilities/sequence-editor/tree-utils.ts Outdated Show resolved Hide resolved
src/utilities/codemirror/vml/vmlTreeUtils.test.ts Outdated Show resolved Hide resolved
@joswig joswig force-pushed the feat/show_variables_in_form_view branch from 8378264 to 9eea635 Compare November 6, 2024 02:05
@joswig joswig requested a review from duranb November 8, 2024 17:50
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@joswig joswig merged commit 0f606b6 into develop Nov 9, 2024
5 checks passed
@joswig joswig deleted the feat/show_variables_in_form_view branch November 9, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Phoenix form fill support for variables
3 participants