-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time systems plugin #1342
Merged
Merged
Time systems plugin #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
force-pushed
the
prototype/lmst
branch
from
June 20, 2024 20:39
58ebbaa
to
76439a5
Compare
AaronPlave
force-pushed
the
prototype/lmst
branch
from
July 1, 2024 16:50
65a15df
to
a22d28d
Compare
AaronPlave
had a problem deploying
to
test-workflow
July 1, 2024 16:50 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
July 1, 2024 17:00 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
July 1, 2024 18:32 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
July 2, 2024 23:18 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
July 5, 2024 23:37 — with
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
July 8, 2024 15:41 — with
GitHub Actions
Failure
AaronPlave
force-pushed
the
prototype/lmst
branch
from
July 8, 2024 21:49
100935c
to
aa2980a
Compare
AaronPlave
force-pushed
the
prototype/lmst
branch
from
July 15, 2024 16:58
a6f76bf
to
1aa3e62
Compare
duranb
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duranb
reviewed
Jul 15, 2024
duranb
reviewed
Jul 15, 2024
… for this when using these functions
AaronPlave
force-pushed
the
prototype/lmst
branch
from
July 19, 2024 22:51
7b3e23e
to
81d9b52
Compare
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* add UI plugin architecture with initial support scoped to time systems * use time systems plugin to display and parse times throughout the plans and plan pages * load time plugin if env var set * hold shift to display additional time formats in timeline tooltip when hovering over activities and resources --------- Co-authored-by: Chet Joswig <[email protected]>
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* add UI plugin architecture with initial support scoped to time systems * use time systems plugin to display and parse times throughout the plans and plan pages * load time plugin if env var set * hold shift to display additional time formats in timeline tooltip when hovering over activities and resources --------- Co-authored-by: Chet Joswig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a client side plugin API for time input and display in the plans and plan pages. The UI will now look for a
time-plugin.js
file in thestatic/resources
directory and the UI will load the file if available. This javascript file will supply an asyncgetPlugin
function that provides a partial set of functions and objects according to the plugin type. The plugin can load additional files from thestatic/resources
directory if desired.UI plugin examples repo: https://github.com/NASA-AMMOS/aerie-ui-plugin-examples
Closes #503
Follow up: #1379
Setup:
time-plugin.js
file in each example folder along with any other files in the LMST build directory.PUBLIC_TIME_PLUGIN_ENABLED=true
env variable to determine whether or not to fetch thetime-plugin.js
file fromstatic/resources
. Add this to your.env
and/or to your aerie backend docker-compose file.PUBLIC_TIME_PLUGIN_ENABLED=true
in your.env
resources
directory in the aerie-uistatic
directory and copy the built example files (choose the LMST plugin to start with) intoresources
. For LMST, the kernel files should be kept in akernels
subfolder, mirroring what exists in the plugin.../aerie-ui-plugin-examples/examples/time/lmst/build/:/app/client/resources/
../aerie-ui-plugin-examples/examples/time/lmst/build/resources/kernels/:/app/client/resources/kernels/
Testing:
TODO:
static/resources
in docker container