pr feedback reactive statement not triggered

NASA-AMMOS · Nov 6, 2024 · ab58482 · ab58482
1 parent 9eea635
commit ab58482
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/e2e-tests/fixtures/Sequence.ts b/e2e-tests/fixtures/Sequence.ts
@@ -165,14 +165,14 @@ export class Sequence {
     await this.page.waitForTimeout(1000);
 
     expect(await this.linter.count()).toBe(0);
-    await expect(this.command).toHaveText('C FSW_CMD_0 "ON" "false" 1');
+    await expect(this.command).toHaveText('C FSW_CMD_0 "ON" false 1');
     await this.page
       .locator('fieldset')
       .filter({ hasText: 'enum_arg_0 ONOFF' })
       .getByRole('combobox')
       .selectOption('OFF');
 
-    await expect(this.command).toHaveText('C FSW_CMD_0 "OFF" "false" 1');
+    await expect(this.command).toHaveText('C FSW_CMD_0 "OFF" false 1');
 
     await this.page.getByRole('button', { name: 'Save' }).click();
     await this.page.getByRole('button', { name: 'Close' }).click();

diff --git a/src/components/sequencing/form/ArgTitle.svelte b/src/components/sequencing/form/ArgTitle.svelte
@@ -23,8 +23,8 @@
   let typeInfo: string = '';
   let formattedRange: string = '';
 
-  $: title = getArgTitle(argDef);
   $: typeInfo = compactType(argDef);
+  $: title = getArgTitle(argDef, typeInfo);
   $: formattedRange = formatRange(argDef);
 
   function compactType(argDef: FswCommandArgument): string {
@@ -52,7 +52,7 @@
     return '';
   }
 
-  function getArgTitle(argDef: FswCommandArgument): string {
+  function getArgTitle(argDef: FswCommandArgument, typeInfo: string): string {
     if (
       isFswCommandArgumentRepeat(argDef) &&
       typeof argDef.repeat?.max === 'number' &&
@@ -96,10 +96,12 @@
       <div>{typeInfo}</div>
     {/if}
 
-    <div>Description</div>
-    <div>
-      {argDef.description}
-    </div>
+    {#if argDef.description}
+      <div>Description</div>
+      <div>
+        {argDef.description}
+      </div>
+    {/if}
 
     <div>Value Type</div>