Update fast track to download .env file since mission model template changed #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skovati
approved these changes
Oct 24, 2024
Mythicaeda
reviewed
Oct 24, 2024
| ``` | ||
|
|
||
| If you're running a different OS and do not have [curl](https://curl.se/) available you can [download the docker-compose.yml here](https://raw.githubusercontent.com/NASA-AMMOS/aerie-mission-model-template/main/docker-compose.yml). | ||
| If you're running a different OS and do not have [curl](https://curl.se/) available you can [download the docker-compose.yml here](https://raw.githubusercontent.com/NASA-AMMOS/aerie-mission-model-template/main/docker-compose.yml) and [the .env file here](https://raw.githubusercontent.com/NASA-AMMOS/aerie-mission-model-template/refs/heads/main/.env.template) (rename to `.env`). |
There was a problem hiding this comment.
The template does not have the GITHUB_USER and GITHUB_TOKEN specified. Will this cause issues?
There was a problem hiding this comment.
We shouldn't need it until we need to build models / procedures
There was a problem hiding this comment.
I think they're only required for doing a gradle build - testing docker compose up without them seems to work for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated the mission model template to use a
.envfile but this accidentally broke our Fast Track instructions in the docs. This fixes it by having the user download the.envfile too, maybe later we can talk about if there's a more ergonomic way but this gets it working again.