Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts #159

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Keyboard shortcuts #159

merged 3 commits into from
Jun 7, 2024

Conversation

lklyne
Copy link
Contributor

@lklyne lklyne commented Jun 6, 2024

Add a page that documents keyboard shortcuts across Aerie UI.

  • Link in sidebar at bottom below glossary for discoverability
  • Separated into sections for different pages and panels
  • Adds a <Shortcut /> component that wraps the <kbd> html element with a bit more padding

Future work:

  • This list may not be exhaustive. We should continue the round up and add additional shortcuts as they come up
  • Could also be useful to add docs around the context menus
  • We may consider adding a link to this from within aerie-ui

image

@lklyne lklyne requested a review from dandelany June 6, 2024 19:09
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments but otherwise looks great!

Copy link
Collaborator

@dandelany dandelany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @lklyne! I'll go ahead and merge/publish this now since it's not directly related to the 2.13 release.

@dandelany dandelany merged commit f4a4b13 into develop Jun 7, 2024
1 check passed
@dandelany dandelany deleted the keyboard-shortcuts branch June 7, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants