Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxHeight to SDD diagrams so they aren't squished #109

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

andreamconnell
Copy link
Contributor

Add maxHeight to SDD diagrams to allow growth

custom.css has a default maxHeight relative to viewport size, which makes these diagrams squished when they have a width set. If the width is removed, the diagrams are too small to view. Setting the maxHeight style here lets them size themselves more naturally.

before:
image

after:
image

custom.css has a default maxHeight relative to viewport size, which
makes these diagrams squished when they have a width set.
If the width is removed, the diagrams are too small to view.
Setting the maxHeight style here lets them size themselves more
naturally.
Copy link
Contributor

@Mythicaeda Mythicaeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattdailis mattdailis merged commit 4834ea9 into develop Jan 16, 2024
1 check passed
@mattdailis mattdailis deleted the fix-SDD-images branch January 16, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants