Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh Start #91

Closed
wants to merge 11 commits into from
Closed

Fresh Start #91

wants to merge 11 commits into from

Conversation

cschuchardt88
Copy link

@cschuchardt88 cschuchardt88 commented Oct 9, 2023

Change Log

  • Updated to neo v3.6.0
  • Updated to neo-modules v3.6.1
  • Naming conventions
  • Renamed Folders
  • Renamed Namespaces
  • Removed unnecessary or broken configurations
  • Added .editorconfig
  • Updated .gitignore
  • Updated nuget.config
  • Update Github Workflows
  • Removed unused or unnecessary packages and files from projects.

image

@cschuchardt88
Copy link
Author

cschuchardt88 commented Oct 11, 2023

I think i fixed the whitespace and line endings. Idk why windows server complains about LF in *.csproj files.

Also is there anyway you can make github, auto run actions for PRs? At least for me until i become contributor of this repo. so I can fix up the action.

@cschuchardt88
Copy link
Author

cschuchardt88 commented Oct 11, 2023

what version should i set the package to? 3.6.0? forgot to added it.

@Ashuaidehao
Copy link
Contributor

what version should i set the package to? 3.6.0? forgot to added it.

It used NerdBank.GitVersioning to auto generate version number, you don't need to remove the package and its "version.json" file.

@cschuchardt88
Copy link
Author

cschuchardt88 commented Oct 11, 2023

I think i got building right
image

But think we need to have clean start. Like how i configured this repo in PR. It more understandable for someone that is just coming in reading the code. we all and me personally should not support bad coding standards and practices.

@cschuchardt88
Copy link
Author

this one has all the fixes to get neo-express/ worknet / trace working

@cschuchardt88 cschuchardt88 closed this by deleting the head repository Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants