fixed all requests

[maharajamihir]

Shortly describe your proposed changes:
Tests for BinomialHeap.java

Link any issues if they have led to changes in the request:

sorry for creating another pull request... one year into computer science and i still dont get git :/

Note the (sub-)exercises the tests are meant for:

• GAD 8 - Binomial Heap: BinomialHeap.java

[CrsiX]

Well, the knowledge how to use git and related tools will come over time, for sure. Thanks for addressing the previously mentioned changes :)
I will have a look into it later on to merge this request, if nobody else has something to comment on it, @N0W0RK?

[N0W0RK]

I like the improvements. I would ask you to fix the remaining codestyle issues and issues I raised.
The handling of git can be learned, if you need help message me on zulip @konrad Gößmann.

[maharajamihir]

The codestyle is complaining about tabs and white characters. I autoformatted it with eclipse. Thats all i can do. I hope this is enough for those simple tests.

[N0W0RK]

So most of it is alright. I just have issues with the two open conversations. If you tell me why your code in line #83 works the way you want it, I would also resolve that conversation.
The codestyle issues are with your javadoc, where you have * at the end of the line, where just * would be appropriate. The issue with tabs stems from your indentation with spaces in the javadoc, but tabs in code.

[maharajamihir]

Line 83:

The method testBigNumbers in general just adds a lot of numbers to the binomial heap. It just tests its min on the way. The real magic is when it starts deleting its min and comparing it to the min of the list. It just keeps adding elements to the datastructures each iteration to hold their size.

Javadoc space:

Unfortunately i dont quite get what u mean by the javadoc spacing. When i autoformat it with eclipse it just goes back to how it was. Does the extra space really matter?
If it does, would you please remove it?

[N0W0RK]

Basically, your indents between the stars and the beginning of your comment starting at line #19 use spaces. If you want to learn the reasoning behind this, have a look here.

Sadly I can't edit the file before it is merged onto the repo.

[N0W0RK]

The package also has to be changed to tests.binomilia

[CrsiX]

I just fixed the small point you mentioned, @N0W0RK. So far, I would say we can just merge the PR (I know that there are some remaining issues with tabs and spaces, but this could be addressed in #49, too).

Thanks, @maharajamihir for the work you did :)

[CrsiX]

Okay. So, the remaining issues have been fixed now, finally :)
I will merge and close this PR now.