[TASK] Update the development tools #1383
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
config/php-cs-fixer.php
Outdated
| // `'methods' => ['createStub' => 'this']` is required as long as we are not on PHPUnit 10.x yet | ||
| // (where that method was made static). | ||
| 'php_unit_test_case_static_method_calls' => ['call_type' => 'self', 'methods' => ['createStub' => 'this']], |
There was a problem hiding this comment.
I'm surprised that we need this, given that we do not call createStub AFAICS, and neither does PHPUnit itself. I'm also mystified as to what change between 3.64 and 3.66 of the Fixer means that we would now need it.
There was a problem hiding this comment.
Some background on this:
PHPUnit provides two kinds of test doubles: Mocks and stubs. They work in similar ways, and using the correct type helps both the reader recognize the purpose of the corresponding test double more easily as well as PHPStan to recognize incorrect usage.
With PHPUnit version 10, the method createStub was made static.
PHP-CS-Fixer 3.66.0 introduced the feature of (by default) making calls to createStub static as well, which breaks tests that are on PHPUnit 9.x. (Up to and including version 3.65.0, PHP-CS-Fixer left calls to createStub alone AFAIK.)
As we're currently using neither getMock nor getStub, I'll remove the corresponding line from the PHP-CS-Fixer configuration to keep things simple.
We're not using `createStub` at this point (and also not `createMock`, so let's keep the PHP-CS-Fixer configuration simple for now.
oliverklee
force-pushed
the
task/dev-tools
branch
from
ac9e389 to
2a4c00f
Compare
No description provided.