[TASK] Upgrade to PHPStan 2.x and Rector 2.x #1376
Conversation
|
For this change, we'll need to drop support for PHP < 7.4 first. |
|
|
||
| # Allow instanceof checks, particularly in tests | ||
| checkAlwaysTrueCheckTypeFunctionCall: false |
There was a problem hiding this comment.
I agree this check should not be disabled per se, and if possible the setting could be applied on a per directory basis: i.e. for tests which can by static analysis be proven to pass. Though I'd quite like the double confirmation.
It's just a dev requirement. |
No, not as far as I know. |
|
We could allow both versions, though. |
Yes, I think that's the solution, with |
We'll allow `assertInstanceOf` checks in the tests again in a later change.
oliverklee
force-pushed
the
task/update-rector-phpstan
branch
from
8c04331 to
597ee7f
Compare
| ignore: | ||
| - dependency-name: "phpstan/*" | ||
| - dependency-name: "phpunit/phpunit" | ||
| versions: [ ">= 10.0.0" ] | ||
| - dependency-name: "rawr/cross-data-providers" | ||
| - dependency-name: "rector/rector" |
There was a problem hiding this comment.
I presume that the GitHub action is unable to cope with OR depencies. This can be revisted later if and when it is able.
We'll allow
assertInstanceOfchecks in the tests again in a later change.