Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UBO-378 Allow to choose data sources used for enrichment in list import #439

Closed
wants to merge 12 commits into from
Closed

UBO-378 Allow to choose data sources used for enrichment in list import #439

wants to merge 12 commits into from

Conversation

Possommi
Copy link
Collaborator

@Possommi Possommi commented Dec 3, 2024 •
edited by jira bot
Loading

@Possommi Possommi requested review from fluetze and kkrebs December 3, 2024 11:14
@fluetze fluetze requested review from kponten and removed request for fluetze December 3, 2024 11:25
fluetze
fluetze requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@fluetze fluetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what we need, I assume, cause the data source configs are hard-coded in the xed file. Selection should be similar to enrichmentDebugger.xed, which uses
<xed:source uri="cache:enrichmentConfig:custom" />

@Possommi Possommi force-pushed the issues/UBO-378-Allow-to-choose-data-sources-used-for-enrichment-in-list-import branch 2 times, most recently from 6984b4e to 4a889de Compare December 3, 2024 13:16
@Possommi Possommi requested a review from fluetze December 3, 2024 13:21
@Possommi Possommi force-pushed the issues/UBO-378-Allow-to-choose-data-sources-used-for-enrichment-in-list-import branch 8 times, most recently from 34776df to 6f3fb3e Compare December 6, 2024 09:58
@Possommi Possommi force-pushed the issues/UBO-378-Allow-to-choose-data-sources-used-for-enrichment-in-list-import branch 2 times, most recently from e8de722 to 238021d Compare December 11, 2024 18:42
@Possommi
UBO-378 Added form elements to import-list.xed for selecting DataSour…
52f3713 
…ces for enrichment
@Possommi
UBO-378 Allow to handle custom enrichment config ids in DozBibImportS…
788a2b9 
…ervlet and ImportJob
@Possommi
UBO-378 Added toggleDataSources to ImportList.js
ac722da
@Possommi
UBO-378 Added class EnrichmentConfigMgr to reuse code in ImportListJo…
e959d07 
…bAction
@Possommi
UBO-378 Load existing configs via uri resolver and do not cach in enr…
b793914 
…ichmentDebugger.xed
@Possommi
UBO-378 Fixed javadoc
46d9ebf
@Possommi
UBO-378 Removed class form-control from select affected by bootstrap-…
4840300 
…select
@Possommi
UBO-378 Added class attributes to selects
e632d99
@Possommi
UBO-378 Updated javadoc in EnrichmentConfigMgr
f3af053
@Possommi
UBO-378 Simplified control flow
99e0734
@Possommi
UBO-378 Include changes from UBO-372
7b4756a
@Possommi
UBO-378 Updated col classes for DataSource select and input
3aa1ab7
@Possommi Possommi force-pushed the issues/UBO-378-Allow-to-choose-data-sources-used-for-enrichment-in-list-import branch from 238021d to 3aa1ab7 Compare December 12, 2024 11:19
kkrebs
kkrebs requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@kkrebs kkrebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems not to be rebased right, looks broken now for me again. Can you check this?

@Possommi
Copy link
Collaborator Author

Can you provide screenshots? Tested with ThUniBib, and it looked good.

@Possommi Possommi closed this Dec 12, 2024
@Possommi Possommi deleted the issues/UBO-378-Allow-to-choose-data-sources-used-for-enrichment-in-list-import branch December 12, 2024 18:43
@Possommi Possommi restored the issues/UBO-378-Allow-to-choose-data-sources-used-for-enrichment-in-list-import branch December 12, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrebs kkrebs kkrebs requested changes

@kponten kponten Awaiting requested review from kponten

@fluetze fluetze Awaiting requested review from fluetze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Possommi @kkrebs @fluetze