Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCR-2647 hibernate 6 jpa 3.1 #1587

Merged
merged 9 commits into from
Nov 3, 2023
Merged

Conversation

yagee-de
Copy link
Member

@yagee-de
Copy link
Member Author

Waits currently for fix of https://hibernate.atlassian.net/browse/HHH-15331

@yagee-de yagee-de force-pushed the issues/MCR-2647-Hibernate-6-JPA-3.1 branch from ed0040f to 1d3a072 Compare August 25, 2022 04:35
@yagee-de yagee-de force-pushed the issues/MCR-2647-Hibernate-6-JPA-3.1 branch 2 times, most recently from ee6f60e to 74cb9a1 Compare October 13, 2023 17:33
@yagee-de yagee-de marked this pull request as ready for review October 13, 2023 17:36
@yagee-de
Copy link
Member Author

Ready for review!
Includes latest hibernate and H2 version
Tested with MyCoRe-Org/mir#907

@rsteph-de
Copy link
Member

We have already MyCoRe applications, that are based the main branch / LTS 2023.06 and in production.
This change needs a migration guide and the merge should be announced on the developer's list.

As far as I can see, at least the persistence.xml changes. Anything else?

@yagee-de
Copy link
Member Author

yagee-de commented Oct 16, 2023

We have already MyCoRe applications, that are based the main branch / LTS 2023.06 and in production. This change needs a migration guide and the merge should be announced on the developer's list.

As far as I can see, at least the persistence.xml changes. Anything else?

Tested with postgres in mir-docker and this requires no migration, also those old properties (javax.* instead of jakarta.*) seems to work (but produce a warning).

For development environments this requires to migrate to a newer version of H2.

  1. Use web console with your old version of h2
    java -jar h2-1.4.199.jar and connect to your database (same URI as in persistence.xml)
    export database to SQL file
    SCRIPT TO '/path/to/backup-1.4.sql'
    stop old H2 instance
  2. Move or delete H2-Database directory
  3. Create new database with version 2.2.x
  4. Connect to new database (same steps as in 1. but with newer version of H2)
    RUNSCRIPT FROM '/path/to/backup-1.4.sql' FROM_1X
    ALTER TABLE MCRUSERATTR ALTER COLUMN "VALUE" RENAME to "value"

@yagee-de
Copy link
Member Author

Also note: If you have custom JQL queries in your code: They are validated more strictly and no "guessing" is done anymore in Hibernate 6.x. But all those obstacles in MyCoRe should be tackled in this PR.

@yagee-de yagee-de changed the base branch from main to 2023.06.x November 3, 2023 09:26
@yagee-de yagee-de force-pushed the issues/MCR-2647-Hibernate-6-JPA-3.1 branch from 74cb9a1 to bbcbab8 Compare November 3, 2023 17:52
@yagee-de yagee-de merged commit 423c8a8 into 2023.06.x Nov 3, 2023
3 checks passed
@yagee-de yagee-de deleted the issues/MCR-2647-Hibernate-6-JPA-3.1 branch November 3, 2023 18:31
sebhofmann added a commit that referenced this pull request Nov 23, 2023
* 2023.06.x:
  MCR-2647 hibernate 6 jpa 3.1 (#1587)
  MCR-2959 fix property guid xslt directory
  MCR-2964 [jobqueue] update yarn dependencies
  MCR-2966 move saxon compatible stylesheets to folder xslt (#1964)
  MCR-2990 Added support of <xinclude @uri="..."/> element. (#1988)
  MCR-2993 Fixed NullPointerException
  MCR-2995 always return Source with systemId (#1995)
  MCR-2998 add save-xsl to xslt folder (#1997)
  MCR-3000 fix exception in MCRACLResolver on factbased access system (#2000)
  MCR-3002 Fix Javadoc for log4j2 (#2008)  MCR-2995 always return Source with systemId (#1995)
  MCR-3002 fix log4j2 javadoc URL
  MCR-3003 jobs in queue do not trigger onCommitTasks
  Revert "MCR-3002 fix log4j2 javadoc URL"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants