Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIR-1241 Response mir facets should be dynamic #901

Merged

Conversation

levshyn
Copy link
Contributor

@levshyn levshyn commented Oct 2, 2023

Facets can be added to the address bar

Link to jira.

@Possommi Possommi changed the title Issues/mir 1241 response mir facets should be dynamic MIR-1241 Response mir facets should be dynamic Oct 4, 2023
Copy link
Contributor

@Possommi Possommi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facets.xsl should be renamed to response-facets.xsl to match existing filename convention

@levshyn levshyn force-pushed the issues/MIR-1241-response-mir_facets_should_be_dynamic branch from 5552b76 to 4c7a962 Compare October 24, 2023 08:43
@Possommi Possommi self-requested a review October 25, 2023 11:50
@Possommi Possommi changed the base branch from 2022.06.x to 2023.06.x November 7, 2023 08:28
Copy link
Contributor

@kkrebs kkrebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed we should integrate changes from MIR-1251

@Possommi Possommi force-pushed the issues/MIR-1241-response-mir_facets_should_be_dynamic branch from c04da1c to 6521cda Compare November 17, 2023 09:38
@Possommi Possommi requested review from kkrebs and toKrause November 17, 2023 11:41
Possommi and others added 12 commits December 4, 2023 11:26
…into a separate facets.xsl file; improved usability and customized the code in the mir_results.scss file; added some facets to the solr-config.json file and corresponding messages to messages_*.properties files.
…ndler /select, remove some new messages from messages_*.properties
…into a separate facets.xsl file; improved usability and customized the code in the mir_results.scss file; added some facets to the solr-config.json file and corresponding messages to messages_*.properties files.
@Possommi Possommi force-pushed the issues/MIR-1241-response-mir_facets_should_be_dynamic branch from 443e6b9 to 250845f Compare December 4, 2023 10:26
@Possommi Possommi marked this pull request as draft December 4, 2023 13:52
@Possommi Possommi marked this pull request as ready for review December 5, 2023 09:01
@toKrause
Copy link
Contributor

toKrause commented Dec 5, 2023

as discussed we should integrate changes from MIR-1251

changes from MIR-1251 and MIR-1262 have been integrated in this PR

@kkrebs kkrebs merged commit eb13e20 into 2023.06.x Dec 5, 2023
2 checks passed
@kkrebs kkrebs deleted the issues/MIR-1241-response-mir_facets_should_be_dynamic branch December 5, 2023 14:02
yagee-de added a commit that referenced this pull request Dec 21, 2023
* 2023.06.x:
  MCR-2647 update database configuration (#935)
  enable docker builds for version 2023.06 in github workflow
  Bump ckeditor-wordcount-plugin from 1.17.6 to 1.17.12 in /mir-module
  MCR-3010 Duplicate warnings about old absolute include mechanism congest logs  (#936)
  MIR-1241 Response mir facets should be dynamic (#901)
  Sort pom (#937)
  MCR-2647 fix db config
  updates LICENSE.txt due to plugin updates
  MIR-1231 Expect dates in ISO8601 to be in ISO8601 basic format.
  MIR-1257 sort 'register PI' menu entries
  MIR-1226 rework subject editor (#885)
  MIR-1248 check if @valueURI contains # - is a classification accordingly
  MIR-1251 add support for arbitrary classification facets w/o the need for specialized SOLR fields
  MIR-1254 optionally allow HTML content in validateion messages
  MIR-1231 Expect dates in ISO8601 to be in ISO8601 basic format. Allow to depict intervalls in that format too. No timezones are supported.
  MIR-1250 Set q.alt parameter on /find request handler (#914)
  MCR-2647 update to hibernate 6.3 and H2 2.2 (#907)
  MCR-2966 move Saxon ready stylesheets to /xslt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants