-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIR-1226 rework subject editor #885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebhofmann
force-pushed
the
issues/MIR-1226-rework_subject_editor
branch
from
August 25, 2023 12:37
692fd86
to
694b9e2
Compare
xaher
force-pushed
the
issues/MIR-1226-rework_subject_editor
branch
from
August 30, 2023 09:44
694b9e2
to
1178bc8
Compare
sebhofmann
force-pushed
the
issues/MIR-1226-rework_subject_editor
branch
2 times, most recently
from
October 27, 2023 08:32
0e05bc0
to
092568c
Compare
kkrebs
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you resolve conflict and fix minor layout bug as discussed?
sebhofmann
force-pushed
the
issues/MIR-1226-rework_subject_editor
branch
from
November 20, 2023 09:32
092568c
to
327bf18
Compare
- Changed label in editor from "Schlagwortgruppe:" to "Schlagwort / Schlagwortgruppe:" to indicate that you can also enter just normal subjects - Added a checkbox to the search facet to disable/enable all checkboxes at once - Changed search behavior to not return anything if no checkbox is selected - Added fa-fw to the icons to fix the weird different spaces after the icon (they now all have the same size)
kkrebs
approved these changes
Nov 21, 2023
yagee-de
added a commit
that referenced
this pull request
Dec 21, 2023
* 2023.06.x: MCR-2647 update database configuration (#935) enable docker builds for version 2023.06 in github workflow Bump ckeditor-wordcount-plugin from 1.17.6 to 1.17.12 in /mir-module MCR-3010 Duplicate warnings about old absolute include mechanism congest logs (#936) MIR-1241 Response mir facets should be dynamic (#901) Sort pom (#937) MCR-2647 fix db config updates LICENSE.txt due to plugin updates MIR-1231 Expect dates in ISO8601 to be in ISO8601 basic format. MIR-1257 sort 'register PI' menu entries MIR-1226 rework subject editor (#885) MIR-1248 check if @valueURI contains # - is a classification accordingly MIR-1251 add support for arbitrary classification facets w/o the need for specialized SOLR fields MIR-1254 optionally allow HTML content in validateion messages MIR-1231 Expect dates in ISO8601 to be in ISO8601 basic format. Allow to depict intervalls in that format too. No timezones are supported. MIR-1250 Set q.alt parameter on /find request handler (#914) MCR-2647 update to hibernate 6.3 and H2 2.2 (#907) MCR-2966 move Saxon ready stylesheets to /xslt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.