Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIR-1226 rework subject editor #885

Merged
merged 12 commits into from
Nov 21, 2023
Merged

Conversation

sebhofmann
Copy link
Member

@sebhofmann sebhofmann marked this pull request as draft July 20, 2023 16:44
@MyCoRe-Org MyCoRe-Org deleted a comment from sonatype-lift bot Jul 20, 2023
@sebhofmann sebhofmann marked this pull request as ready for review August 25, 2023 12:33
@sebhofmann sebhofmann force-pushed the issues/MIR-1226-rework_subject_editor branch from 692fd86 to 694b9e2 Compare August 25, 2023 12:37
@xaher xaher force-pushed the issues/MIR-1226-rework_subject_editor branch from 694b9e2 to 1178bc8 Compare August 30, 2023 09:44
@sebhofmann sebhofmann force-pushed the issues/MIR-1226-rework_subject_editor branch 2 times, most recently from 0e05bc0 to 092568c Compare October 27, 2023 08:32
@yagee-de yagee-de changed the base branch from main to 2023.06.x November 3, 2023 10:37
Copy link
Contributor

@kkrebs kkrebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you resolve conflict and fix minor layout bug as discussed?

@sebhofmann sebhofmann force-pushed the issues/MIR-1226-rework_subject_editor branch from 092568c to 327bf18 Compare November 20, 2023 09:32
- Changed label in editor from "Schlagwortgruppe:" to "Schlagwort / Schlagwortgruppe:" to indicate that you can also enter just normal subjects
- Added a checkbox to the search facet to disable/enable all checkboxes at once
- Changed search behavior to not return anything if no checkbox is selected
- Added fa-fw to the icons to fix the weird different spaces after the icon (they now all have the same size)
@kkrebs kkrebs merged commit a5feaf4 into 2023.06.x Nov 21, 2023
2 checks passed
@kkrebs kkrebs deleted the issues/MIR-1226-rework_subject_editor branch November 21, 2023 14:40
yagee-de added a commit that referenced this pull request Dec 21, 2023
* 2023.06.x:
  MCR-2647 update database configuration (#935)
  enable docker builds for version 2023.06 in github workflow
  Bump ckeditor-wordcount-plugin from 1.17.6 to 1.17.12 in /mir-module
  MCR-3010 Duplicate warnings about old absolute include mechanism congest logs  (#936)
  MIR-1241 Response mir facets should be dynamic (#901)
  Sort pom (#937)
  MCR-2647 fix db config
  updates LICENSE.txt due to plugin updates
  MIR-1231 Expect dates in ISO8601 to be in ISO8601 basic format.
  MIR-1257 sort 'register PI' menu entries
  MIR-1226 rework subject editor (#885)
  MIR-1248 check if @valueURI contains # - is a classification accordingly
  MIR-1251 add support for arbitrary classification facets w/o the need for specialized SOLR fields
  MIR-1254 optionally allow HTML content in validateion messages
  MIR-1231 Expect dates in ISO8601 to be in ISO8601 basic format. Allow to depict intervalls in that format too. No timezones are supported.
  MIR-1250 Set q.alt parameter on /find request handler (#914)
  MCR-2647 update to hibernate 6.3 and H2 2.2 (#907)
  MCR-2966 move Saxon ready stylesheets to /xslt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants