MIR-1412 Show MD5 sum for each file in the derivate file list #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possommi
requested changes
Nov 26, 2024
mir-layout/src/main/resources/META-INF/resources/mir-layout/scss/common/mir_browse.scss
Outdated
Show resolved
Hide resolved
mir-module/src/main/resources/META-INF/resources/hbs/derivate-fileList.hbs
Outdated
Show resolved
Hide resolved
mir-module/src/main/resources/META-INF/resources/hbs/derivate-fileList.hbs
Outdated
Show resolved
Hide resolved
Possommi
changed the title
Possommi
approved these changes
Nov 26, 2024
golsch
requested changes
Dec 2, 2024
Comment on lines
333
to
362
| const toggleMD5LinkElement = '#toggleMD5Link'; | ||
| // Derivate action dropdown toggle button element | ||
| const derivateActionDropdownToggleButton = '.headline .dropdown.options .dropdown-toggle'; | ||
| // Element selector with md5 information | ||
| const md5ElementSelector = '.file_md5'; | ||
|
|
||
| // Show md5 sums by derivate files by clicking on the 'toggleMD5LinkElement' element | ||
| $(toggleMD5LinkElement).click((evt) => { | ||
| evt.preventDefault(); | ||
| // Get the element to show/hide | ||
| const elements = document.querySelectorAll(md5ElementSelector); | ||
|
|
||
| elements.forEach(element => { | ||
| element.classList.toggle('hidden'); | ||
| }); | ||
| }); | ||
|
|
||
| // Getting i18n translation for the link to switch state 'show/hide MD5 amounts' depending on the visibility of the | ||
| // message with this amount when clicking on the 'derivateActionDropdownToggleButton' element | ||
| $(derivateActionDropdownToggleButton).click((evt) => { | ||
| if ($(md5ElementSelector)) { | ||
| let i18nKey = ''; | ||
| if ($(md5ElementSelector).hasClass('hidden')) { | ||
| i18nKey = 'component.mods.metaData.options.MD5.show'; | ||
| } else { | ||
| i18nKey = 'component.mods.metaData.options.MD5.hide'; | ||
| } | ||
| getI18n(i18nKey, toggleMD5LinkElement); | ||
| } | ||
| }); |
There was a problem hiding this comment.
use 2 spaces. Encapsulate the code to improve overview (IIFE).
Comment on lines
354
to
359
| let i18nKey = ''; | ||
| if ($(md5ElementSelector).hasClass('hidden')) { | ||
| i18nKey = 'component.mods.metaData.options.MD5.show'; | ||
| } else { | ||
| i18nKey = 'component.mods.metaData.options.MD5.hide'; | ||
| } |
There was a problem hiding this comment.
const i18nKey = md5Elements.hasClass('hidden')
? 'component.mods.metaData.options.MD5.show'
: 'component.mods.metaData.options.MD5.hide';
| // Getting i18n translation for the link to switch state 'show/hide MD5 amounts' depending on the visibility of the | ||
| // message with this amount when clicking on the 'derivateActionDropdownToggleButton' element | ||
| $(derivateActionDropdownToggleButton).click((evt) => { | ||
| if ($(md5ElementSelector)) { |
There was a problem hiding this comment.
use $(md5ElementSelector).length > 0, because this check is always true.
There was a problem hiding this comment.
I use now $(md5ElementSelector).length, see link: https://learn.jquery.com/using-jquery-core/faq/how-do-i-test-whether-an-element-exists/
|
|
||
| // Getting i18n translation for the link to switch state 'show/hide MD5 amounts' depending on the visibility of the | ||
| // message with this amount when clicking on the 'derivateActionDropdownToggleButton' element | ||
| $(derivateActionDropdownToggleButton).click((evt) => { |
There was a problem hiding this comment.
I would define the dropdown more explicitly, the display should only refer to a specific derivate.
but we need this in 2023.06.x |
kkrebs
approved these changes
Dec 5, 2024
kkrebs
deleted the
issues/MIR-1412-Show_MD5_sum_for_each_file_in_the_derivate_file_list
branch
yagee-de
added a commit
that referenced
this pull request
Dec 18, 2024
* 2023.06.x: MIR-1416 pin glassfish jaxb-runtime to MIRAccessKeyPairTransformer MIR-1412 Show MD5 sum for each file in the derivate file list (#1089) MIR-1413-subject xml:lang should not be removed MIR-1408 Added class attributes to list items in action menu (#1083) MIR-1361 Allow to enter ROR as affiliation for authors (#1074) MIR-1365 Allow to configure max value for xed template subject.simple and subject.simple.required MIR-1359 fix choose publication button in related item (#1071) Bump express in /mir-webapp/src/main/vue/name-search Bump dompurify in /mir-webapp/src/main/vue/editor-tools Bump webpack in /mir-webapp/src/main/vue/editor-tools Bump braces from 3.0.2 to 3.0.3 in /mir-wizard
yagee-de
added a commit
that referenced
this pull request
Dec 18, 2024
* 2024.06.x: Bump nanoid from 3.3.6 to 3.3.8 in /mir-webapp/src/main/vue/name-search MIR-1416 pin glassfish jaxb-runtime to MIRAccessKeyPairTransformer MIR-1412 Show MD5 sum for each file in the derivate file list (#1089) Update README.md (#1091) MIR-1413-subject xml:lang should not be removed MIR-1408 Added class attributes to list items in action menu (#1083) Bump http-proxy-middleware in /mir-webapp/src/main/vue/name-search Bump express in /mir-webapp/src/main/vue/editor-tools Update README.md (#1086) MIR-1361 Allow to enter ROR as affiliation for authors (#1074) update PMD ruleset.xml (#1082) MIR-1365 Allow to configure max value for xed template subject.simple and subject.simple.required MIR-1359 fix choose publication button in related item (#1071) Bump express in /mir-webapp/src/main/vue/name-search Bump dompurify in /mir-webapp/src/main/vue/editor-tools Bump webpack in /mir-webapp/src/main/vue/editor-tools Bump braces from 3.0.2 to 3.0.3 in /mir-wizard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of derivate files should have the ability to display the MD5 amount
MIR-1412.