-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIR-1343 Do not render mir-admindata-box staticly #1040
MIR-1343 Do not render mir-admindata-box staticly #1040
Conversation
Code looks okay and I've tested the modified feature in my development system. One thing needs to be considered: Once the changes in this PR are applied, already existing statically cached content (that still contains HTML) is unsuitable to be rendered with the updated style sheets. It will look something like this: After any change, the newly created statically cached content (that now contains XML) works fine. It will look something like this: Since this PR targets the LTS branch, some migration strategy has to be devised and implemented. Ideally, one, that is going to be performed automatically. What are your plans here? Once a migration strategy has been devised and implemented, I will approve this PR. |
[1] Executing [2] Alternatively I could add a check in
I do prefer [1] although [2] requires no additional user actions after upgrading to the new LTS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version [1] would certainly be simpler and would be okay (if documented in the migration documentation), if this PR would target the main branch, but since this PR targets the LTS branch, there really should be no manual migration step.
So, version [2], if I understand it correctly, wold render an old static file in the old way and a new static file in the new way. I don't think that is a desirable solution, since it would be unclear users why the history (seemingly on a random basis) has a different behavior for different objects.
I think a solution should be invented, that automatically creates the missing/unfit static data for in the new way if no/old static data is found.
mir-module/src/main/java/org/mycore/mir/migration/MIRMigrateStaticHistoryContentJobAction.java
Outdated
Show resolved
Hide resolved
mir-module/src/main/java/org/mycore/mir/migration/MIRMigrateStaticHistoryContent.java
Outdated
Show resolved
Hide resolved
* 2023.06.x: fix github actions MIR-1347-allow to change the number of entries per page of the filebox with a property MIR-1346 Allow to add custom meta elements in mir-flatmir-layout.xsl MIR-1349 include ID correctly MIR-1348 Provide realm of user in link to profile Bump follow-redirects in /mir-webapp/src/main/vue/name-search (#981) Bump follow-redirects in /mir-webapp/src/main/vue/editor-tools (#982) Bump webpack-dev-middleware in /mir-webapp/src/main/vue/name-search (#985) Bump express in /mir-webapp/src/main/vue/editor-tools (#993) Bump express in /mir-webapp/src/main/vue/name-search (#994) Bump micromatch in /mir-webapp/src/main/vue/editor-tools (#1050) Bump webpack in /mir-webapp/src/main/vue/name-search (#1051) MIR-1336 Display realname of creator/modifier in mir-admin-box (#1031) MIR-1343 Do not render mir-admindata-box staticly (#1040) MIR-1344 update JavaScript dependencies Bump select2 from 4.0.6-rc.1 to 4.0.6 in /mir-module MIR-1338 fixed missing url encoding in solr query (#1033) MIR-1337 fix property to control display of real name (#1032) MIR-1339 Obtain ORCID from lobid in xEditor name search (#1034) Bump jsoup from 1.15.2 to 1.15.3
MIR-1343 and MIR-1341
requires MyCoRe-Org/mycore#2215 to render the dates properly