Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIR-1333 Added placeholder for username input field in new-author.xed #1037

Open
wants to merge 2 commits into
base: 2023.06.x
Choose a base branch
from
Open

MIR-1333 Added placeholder for username input field in new-author.xed #1037

wants to merge 2 commits into from

Conversation

Possommi
Copy link
Contributor

@Possommi Possommi commented Jul 26, 2024 •
edited by jira bot
Loading

@Possommi Possommi requested a review from toKrause July 26, 2024 07:47
toKrause
toKrause reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@toKrause toKrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same field has the attribute i18n.error="component.user2.admin.inputhints.username".

Currently, component.user2.admin.inputhints.username translates to
Benutzerkennungen d\u00FCrfen nur maximal 16 Zeichen lang sein und nur aus Kleinbuchstaben und/oder Zahlen bestehen. Umlaute, Sonderzeichen und Leerzeichen sind nicht erlaubt. and For user accounts please enter maximum 16 characters only lower case or numbers. Umlauts, special characters and blanks are not allowed! respecively. But some special charactes (., _, -) are allowed.

Could you adjust the error message to better reflect the actual requirements as part of this change?

@toKrause
Copy link
Contributor

toKrause commented Jul 26, 2024 •
edited
Loading

Could you adjust the error message to better reflect the actual requirements as part of this change?

Never mind, those translations are part of MyCore, not MIR, so a separate PR is needed anyways.

rsteph-de
rsteph-de requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@rsteph-de rsteph-de left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move english message property to proper position

@rsteph-de rsteph-de requested a review from toKrause July 30, 2024 14:32
@sebhofmann
Copy link
Member

sebhofmann commented Jul 30, 2024 •
edited
Loading

maybe try to use @tooltip instead of @placeholder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsteph-de rsteph-de rsteph-de requested changes

@toKrause toKrause toKrause requested changes

@kkrebs kkrebs kkrebs approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Possommi @toKrause @sebhofmann @kkrebs @rsteph-de