Move device-related logic from client to agent #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanogrid
force-pushed
the
entity-migration
branch
from
8f809a2 to
a780ad6
Compare
vanogrid
force-pushed
the
entity-migration
branch
from
a780ad6 to
07f91f9
Compare
dim4o
force-pushed
the
dev
branch
4 times, most recently
from
4639fdb to
55e62b1
Compare
vanogrid
force-pushed
the
entity-migration
branch
2 times, most recently
from
e86923b to
7091ad0
Compare
Migrate HardwareButtonEntity from atmosphere-client
Migrate ImeEntity from atmosphere-client
Migrate GestureEntity and GestureCreator from atmosphere-client
Migrate DeviceSettingsEntity and DeviceSettingsManager from atmosphere-client
Migrate ImageEntity from atmosphere-client
Migrate GpsLocationEntity from atmosphere-client
Set the `deviceId` to the error response closes MusalaSoft/atmosphere-docs#95 closes MusalaSoft/atmosphere-docs#96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the device-related logic from the client to the agent. This way, when a feature for a specific device is added, it is easier to update just the agents instead of all clients.
This pull request should be merged after MusalaSoft/atmosphere-commons#4 is merged
closes MusalaSoft/atmosphere-docs#93
closes MusalaSoft/atmosphere-docs#95
closes MusalaSoft/atmosphere-docs#96
closes MusalaSoft/atmosphere-docs#98