SonarCloud Analysis #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AlbertoBaroso
commented
Mar 15, 2024
AlbertoBaroso
commented
- Added SonarCloud Analysis job in GitHub Actions workflow
- Generated lcov.info coverage reports in test jobs
- Setup analysis configuration in the sonar-project.properties file
friedbyalice
force-pushed
the
feature/sonar-analysis
branch
from
f20c3c4 to
80dcc59
Compare
|
AlbertoBaroso
added a commit
that referenced
this pull request
Apr 9, 2024
* feat: setup coverageDirectory and coveragePathIgnorePatterns * ci: added SonarCloud Analysis job in GitHub actions * ci: sonar-project.properties configuration * Simplified workflow, single task, maximum gain --------- Co-authored-by: Vincenzo Pellegrini <[email protected]>
whiitex
added a commit
that referenced
this pull request
Apr 12, 2024
* Feature/rectuitment session (#20) * feat: session service, controller, entity * feat: update recruitment-session: service, controller, entity * test: mock recruitment session service, insert data mock * fix: relative import of recruitment-session from shared folder * fix: recruitment-session service Delete test * fix: removed lastModified from UpdateRecruitmentSessionDto * fix: ability check on recruitment session creation * feat: check if recruitment session has pending interviews before deleting it * feat: check for conflicts and consistency when updating a recruitment session state * fix: check ability for update recruitment session * refactor: removed unused imports in recruitment-session.controller.ts * fix: use const for unchanged variable in createRecruitmentSession service method * refactor: removed unused code in creatre-recruitment-session.dto.ts * fix: updated Date[] in create and update Recruitment session DTOs * test: Recruitment Session Controller tests * refactor: removed unused imports * feat: Recruitment session module * fix: import of RecruitmentSessionState in recruitment-session.service.ts * fix: find function recreuitment session * fix: set findBy functions * fix: adjustments about array of recruitment session * test: create recruitment session * add: test create RS on service.spec * fix: changed array into scalar value in findBy and findActive --------- Co-authored-by: Alberto Baroso <[email protected]> * feat: created availability module * fix: mock data timestamp for midnight * fix: added http exceptions and removed unnecessary request fields * test: Initial tests for availability controller * test: Initial tests for availability service * fix: relationship between timeslot and availability entities * fix: removed relationship fields in entities * test: CRUD unit tests for availability * RecruitmentSession: controller, service, entity, tests (#15) RecruitmentSessionController: - findActive: Retrieve the active recruitment session if it exists. - createRecruitmentSession - updateRecruitmentSession - deleteRecruitmentSession RecruitmentSessionService: - createRecruitmentSession - findAllRecruitmentSessions - findRecruitmentSessionById - findActiveRecruitmentSession - deletRecruitmentSession - updateRecruitmentSession - sessionHasPendingInterviews: Check if a recruitment session has pending interviews (to be implemented). DTOs: - CreateRecruitmentSessionDTO - UpdateRecruitmentSessionDTO - RecruitmentSessionResponseDTO Tests: - Controller Unit tests: recruitment-session.controller.spec.ts - Service Unit tests: recruitment-session.service.spec.ts Commits: * fix: missing dependencies and imports (#9) * fix: added @joi/date library * fix: added missing useState import fix: removed loading screen when auth token is empty * docs: updated project description, useful links, and contributors in README.md (#10) * feat session: service, controller, entity * feat: update recruitment-session: service, controller, entity * feat: update recruitment-session: service, controller, entity * fix: dependencies in shared/abilities * fix: mock shared -> required/optional fields * fix: mock recruitment session service, insert data mock * fix: relative import of recruitment-session from shared folder * fix: recruitment-session service Delete test * fix: removed lastModified from UpdateRecruitmentSessionDto * fix: ability check on recruitment session creation * feat: check if recruitment session has pending interviews before deleting it * feat: check for conflicts and consistency when updating a recruitment session state * fix: check ability for update recruitment session * refactor: removed unused imports in recruitment-session.controller.ts * fix: use const for unchanged variable in createRecruitmentSession service method * refactor: removed unused code in creatre-recruitment-session.dto.ts * fix: updated Date[] in create and update Recruitment session DTOs * fix: added 'state' to recruitmentSession response DTO * test: Recruitment Session Controller tests * refactor: removed unused imports --------- Co-authored-by: Alberto Baroso <[email protected]> * fix: updated imports from shared/recruitment-session * Feature: Rectuitment session module (#17) * SonarCloud Analysis (#18) * feat: setup coverageDirectory and coveragePathIgnorePatterns * ci: added SonarCloud Analysis job in GitHub actions * ci: sonar-project.properties configuration * Simplified workflow, single task, maximum gain --------- Co-authored-by: Vincenzo Pellegrini <[email protected]> * fix: removed unused avaiability endpoints * feat: added existance checks and conflict check upon availability creation * feat: return 404 when attempting to delete non-existing availabilities refactor: availability.controller.ts using prettier * fix: Availability authorizations and creation schema * fix!: updated AvailabilityState enum values * test: role abilities on Availability test: validate insert Availability schema * feat: additional checks before deleting availability * test: availability controller unit tests * feat: added findByUserAndTimeSlot in Availability service fix: used Relation as type of fields in Availability entity * fix!: removed unnecessary fields in CreateAvailabilityDto * test: Availability service unit tests * fix!: removed create/delete timeslot endpoint * feat: TimeSlot service generateTimeslots() * test: TimeSlot service generateTimeslots() * feat: create recruitment session's timeslots atomically using a transaction * feat: added jest-mock-extended library to auto mock classes * fix: added DbAwareColumn to overcome sqlite column type limitation * fix: apply abilities on TimeSlots * fix: imported missing modules * fix: import Joi in availability controller * test: mock recruitment session for timeslot generation * fix: added coverage exclusions in sonar-project.properties * refactor: format according to prettier rules, reduced code duplication in timeslots.service.spec.ts * feat: User is_board and is_expert flags --------- Co-authored-by: whiitex <[email protected]> Co-authored-by: Marco De Luca <[email protected]> Co-authored-by: whiteOFF <[email protected]> Co-authored-by: Vincenzo Pellegrini <[email protected]> Co-authored-by: Mugna0990 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.